Merged
But thanks for keeping my phone up to date, it is appreciated ♥
this post was submitted on 18 Jan 2024
143 points (100.0% liked)
Programmer Humor
428 readers
1 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 2 years ago
MODERATORS
Same, I run 3 devices all on Lineage and its great. Who know that you could still get updates and support for a device from 10 years ago, suck on that apple.
It's just kind of sucks that updates consistently breaks banking apps and other stuff relying of passing safetynet. Every time I update I have to do the Magisk workaround again which is really annoying.
Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?
Probably to get some other benefitof the PR system, such as CI tests
Does gerrit have a draft state? In azure devops you can mark PR as draft , won't trigger any builds but you can still start them manually
manually
This is probably why the dev created a PR, less clicks
I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅
I do this often. It's useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run
It's been a while since I've worked with AOSP, but I had always understood it to be some weird shit with Google's internal processes. The "do not merge" commits are all over the AOSP, or at least they used to be.
There are a LOT of these in lineage repos. There must be a reason
Maybe they dont use squash merges, so all the intermediate commits remain on-chain?
Nice