kkoyung

joined 2 years ago
[–] kkoyung@masto.kkoyung.dev 1 points 2 years ago

You are doing a great job. It is really hard to keep an instance up with so many new users coming from the unexpected fast growing #RedditMigration.

[–] kkoyung@masto.kkoyung.dev 1 points 2 years ago

@ernest

  1. In the Dockerfile, the kbin-core repository has already been copied to the image. Why we need to mount the repository as volume again with ./:/srv/app in docker-compose.yml? Is it because the front end javascript is built outside the image? (and why those yarn command are not automated in Dockerfile?)

  2. The docker-compose.yml has caddy as reserve proxy. Will it be safe if I directly turn it off, and use my own nginx reserve proxy with my own certificate? (2/2)

[–] kkoyung@masto.kkoyung.dev 1 points 2 years ago (1 children)

@ernest Great work!

I haven't take a deeper look to the code. I just read the current version of instance creation instruction, Dockerfile, and docker-compose.yml. There are somethings I don't understand, which you might find useful in improving docker related stuff. (1/2)