this post was submitted on 16 Sep 2023
48 points (100.0% liked)

Programming

423 readers
2 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] robinm@programming.dev 9 points 1 year ago (2 children)

That's well written. I think that requiered 2+ code review could also help because with time more people will gain knowledge of the dark parts of the codebase, just by reviewing the PR of “Martin” when he work on them.

[–] ColonelPanic@lemm.ee 2 points 1 year ago

That entirely depends on how well code reviews are managed. I've worked with a "Martin" in the past and we did manage to move to a system where 2+ reviewers were required but it simply got to the point where no one would "rock the boat" because he'd simply brush off every comment made, or call you up to have a long rambling conversation as to why he made the decision he did and how you're wrong and he's right, and given his position in the company you couldn't complain to anyone else about him because he was more valuable to them than you were.

We tried to put more and more blockers in front of him to attempt to encourage him to play nicer, but these were only temporary solutions to the bigger problem of "Martin" himself.

[–] potterman28wxcv 1 points 1 year ago (1 children)

If the code base is arcane enough, code reviews won't matter. You just won't understand at all what is happening there. And the "Martin" will probably pressure you to accept anyway by telling the bosses "I can't work, they won't accept my code reviews".

[–] robinm@programming.dev 2 points 1 year ago

That's true. But at least you will have evidence that Martin doesn't conform to the team rules.