this post was submitted on 20 Sep 2024
29 points (100.0% liked)

Linux

1259 readers
63 users here now

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

Related Communities

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

founded 5 years ago
MODERATORS
 

I don't know bash scripting

if [ -d ~/.bashrc.d ]; then
	for rc in ~/.bashrc.d/*; do
		if [ -f "$rc" ]; then
			. "$rc"
		fi
	done

I asked chatgpt and it said this is non standard? There is no bashrc.d directory on my home folder, I have uncommented the lines for now but dont know if this is benign or malignant

top 12 comments
sorted by: hot top controversial new old
[–] MummifiedClient5000@feddit.dk 27 points 1 month ago (1 children)

It sources (includes) any file found in ~/.bashrc.d/ so check that directory.

[–] Artemis_Mystique@lemmy.ml 4 points 1 month ago (2 children)

but there is no such directory

[–] MummifiedClient5000@feddit.dk 25 points 1 month ago

Then it does nothing.

[–] BCsven@lemmy.ca 6 points 1 month ago

It just checks to see if there is anything in a bash.d folder, if there isn't it moves on. Just somebody being preemptively helpful to check for other locations

[–] savvywolf@pawb.social 24 points 1 month ago

Check /etc/skel/.bashrc, if it's in there as well, it was set up by your distro.

What it does is check for the existence of ~/.bashrc.d and, if it finds one, sources all the files inside it. This effectively means that you can create script files like ~/.bashrc.d/myfile.sh and they will have the same effect as if they had been put directly into .bashrc. Some people prefer having one file for each "bashrc thing" whilst some prefer just having one big file. Ultimately it's personal preference.

[–] Badabinski@kbin.earth 16 points 1 month ago

Ugh, I hate ChatGPT. If this is Bash (which it is, because it's literally looking for files in a directory called ~/.bashrc.d), then it should god damned well be using syntax and language features that we've had for at least twenty fucking years. Specifically, if you're writing for Bash (and not POSIX shell), you better be using [[ ]] rather than [ ]. This wiki is my holy book I use to keep the demons away when writing Bash, and it does a simply fantastic job of explaining why you should use God damned double square brackets.

ChatGPT writes shitty, horrible, buggy ass Bash. This is relatively decent for ChatGPT (it even makes sure the files are real files and not symlinks), but I've had to fix enough terrible fucking shitty AI Bash to have no tolerance for even the smallest misstep from it.

Sincerely, A senior developer who is known as the Bash wizard at work.

EDIT: Sorry, OP. ChatGPT did not, in fact, write this code, and I am going to leave my comment here as a testament to what a big smelly dick I was here.

[–] teawrecks@sopuli.xyz 11 points 1 month ago

Looks like this is in the standard Fedora /etc/skel/.bashrc.

[–] Dirk@lemmy.ml 8 points 1 month ago

It first checks if ~/.bashrc.d is an existing directory. If this it the case it then iterates over all entries in that directory. In this iteration it checks if the entry is a file and if this is the case it sources that file using the bash-internal shorthand . for source.

So it basically executes all scripts in ~/.bashrc.d. This makes it possible for you to split your bash configuration into multiple files. This quite common and a lot of programs already support it (100% depends on the program, though).

This is absolutely harmless as it is. But: if you or a program places anything in the directory ~/.bashrc.d it WILL be sourced everytime you start a bash.

A slightly better variant would be iterating over ~/.bashrc.d/*.sh instead of just ~/.bashrc.d/* to make sure to only grab files with the .sh suffix (even if suffixes are basically meaningless from a technical point of view) and also test for the file being executable (-x instead of -f).

This would make sure that only files that are ending with .sh and that are executable are sourced. The “attack vector”, if you want to call it like that, would then be a bit more narrow than just placing a file in a directory.

As for why it’s there: Did you ever touch your .bashrc? If not, maybe it is there since the beginning because it’s in the so-called skeleton (see /etc/skel/.bashrc) that was used to initialize certain files on user account creation.

[–] unterzicht@lemmy.ml 5 points 1 month ago (1 children)

Definitely non-standard, but I have something almost identical that I very consciously added and really simplifies a lot of things.

[–] davel@lemmy.ml 4 points 1 month ago* (last edited 1 month ago)

I couldn’t say how it got there, but it’s a standard & common Unix pattern and unlikely to be malicious. It will have no effect if the ~/.bashrc.d directory doesn’t exist. If it does exist, then each file in the directory will be sourced.

[–] nublug@lemmy.blahaj.zone 1 points 1 month ago

seems similar to the set up for systemd snippets, where you can avoid changing default config files for systemd units and instead use a drop in file in that created .d dir to load and overwrite the defaults on boot for whatever specific thing. don't know anything that uses this for bashrc, tho. most likely harmless, especially if there's no created bashrc.d yet.