this post was submitted on 14 Jun 2023
1 points (100.0% liked)
/kbin meta
200 readers
2 users here now
Magazine dedicated to discussions about the kbin itself. Provide feedback, ask questions, suggest improvements, and engage in conversations related to the platform organization, policies, features, and community dynamics. ---- * Roadmap 2023 * m/kbinDevlog * m/kbinDesign
founded 1 year ago
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
SOOOOOO after finally setting up my kbin dev environment I went ahead and wrote some code to add support for EXACTLY this on the official kbin codebase!
GIF of it in action:
demo
I have a PR up for it already here: https://codeberg.org/Kbin/kbin-core/pulls/167
Now just need @ernest 's approval and once it's merged you'll be able to do this on kbin without any modifications!!!
edit: clicking on a comment now also hides its content (other than the username), making it even more clear which threads are collapsed! (similar to apollo) – updated the demo gif
Nice! Would it be possible to use a little +/- icon somewhere on each comment instead of having it be clicking anywhere on the comment? I could see myself very regularly accidentally collapsing stuff when I don't mean to.
I love the huge touch target for mobile friendliness, and I've done some work to make sure accidental collapses don't happen (if you mean to select text it won't collapse, if you click on a link or a button it won't collapse either!)
is there a common situation where you'd accidentally collapse stuff when you dont mean to?
Like @psyspoop said, touchpads can be prone to accidental collapses. Maybe setting the touch target to be on the "header" of the comment (the whitespace between the username and the upvote/downvote buttons) could be a good compromise?
TBH that's not too hard to do, but it goes back to the whole mobile friendliness :(
IMO i think the upside of mobile friendliness outweigh the times people accidentally tap on touchpad, and i personally think just having the header being a touch target is a little too small for mobile users.. so i prefer the whole comment being a target
obviously if folks disagree heavily i could probably adjust but i'm curious what @ernest thinks
What if there was an option somewhere to switch between the two? Mobile users could keep the full comment collapsing, and web users could switch to header-only collapsing.